feat(server): support single computer do schedule task#2676
Open
shirleyStorage wants to merge 5 commits intoapache:masterfrom
Open
feat(server): support single computer do schedule task#2676shirleyStorage wants to merge 5 commits intoapache:masterfrom
shirleyStorage wants to merge 5 commits intoapache:masterfrom
Conversation
added 3 commits
October 12, 2024 00:31
Signed-off-by: shirley118146 <shirley118146@gmail.com>
Signed-off-by: shirley118146 <shirley118146@gmail.com>
Signed-off-by: shirley118146 <shirley118146@gmail.com>
shirleyStorage
changed the title
dosubot
bot
added
size:M
Contributor
Author
|
@imbajin PTAL~ |
shirleyStorage
changed the title
Contributor
Author
|
@imbajin I updated the test case to the PR description. PTAL ~~ |
Contributor
Author
|
@dosu how to rerun "HugeGraph-Server CI / build-server (hbase, 11)" |
Contributor
2024-10-22.22.40.08.mov |
javeme
reviewed
Oct 27, 2024
Contributor
javeme
left a comment
javeme
left a comment
There was a problem hiding this comment.
Thanks for your contribution.
Can I know in what scenario you need to do this?
|
|
||
| boolean singleNode = !hasWorkerNode||computerNodeCount==1; | ||
| if (singleNode != this.onlySingleNode) { | ||
| LOG.info("Switch only_single_node 02 to {}", singleNode); |
| } | ||
| if (server.role().master()) { | ||
| continue; | ||
| }else if (server.role().computer()){ |
Contributor
There was a problem hiding this comment.
add a space after '}', or remove 'else'
| return this.selfNodeRole() != null && this.selfNodeRole().master(); | ||
| public boolean selfIsMasterOrSingleComputer() { | ||
| boolean isMaster=this.selfNodeRole() != null && this.selfNodeRole().master(); | ||
| boolean isSingleComputer=isStandAloneComputer(); |
| return this.selfNodeRole() != null && this.selfNodeRole().computer(); | ||
| } | ||
|
|
||
| public boolean isStandAloneComputer(){ |
imbajin
changed the title
imbajin
changed the title
Collaborator
|
Hello, I'm trying to disable the server-role option（https://github.com/hugegraph/hugegraph/pull/85）. I'd like to ask what blocked this pr merge before? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the PR
Main Changes
Verifying these changes
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODODoc - DoneDoc - No Need